- Partially reverts changes in 0b362afcc0
- Checks the codestring if its a valid game genie code before attempting
to decode it. If code fails, then assume it to be a pro action replay
cheat.
Issue: Cheats where failing because a value of 0 in the decoder does not
mean an error.
Fix https://github.com/libretro/libretro-fceumm/issues/384
Two issues are causiong PAR cheats to not work.
1. GG decoder should only accept specific characters. When it fails,
assume PAR code.
2. The corrent code that makes PAR decoding work was not set.
Both fixed on this PR with some added notes.
MMC1 overrides are treated as ines 2.0, so its needs at least default values for prgRam and chrRam columns.
Fixes FF1 pink screen due to unmapped chrram.
- Width changes previously was not respected when using ntsc filter. With full use of overscan, nes width
is 602 px when ntsc filter is used and 256 px on normal
- Happens when starting with PAL/Dendy region and changing to NTSC can cause frame to get stuck in 50 Hz
- using RETRO_ENVIRONMENT_SET_SYSTEM_AV_INFO should remedy this.
- We just use shaders for scanline if needed. ntsc + height doubling causes performance hit
for some slow devices. Any decent platform should be able to handle scanline effect shaders at least.
Move mapper-based overrides out and use ines-correct.h if possible. Affects the following mappers below:
- Move Cnrom database to ines-correct.h
- Mapper 201 update
- Mapper 91: Add Street Fighter III (Submapper 1) to ines-correct.h
- Add dipswitch notes to m237
- Update mapper9 (PC10 version of Mike Tyson's Punch-out)
from nesdev notes:
GoodNES 3.23b's "Mortal Kombat Trilogy - 8 People (M1274) (Ch) [!]" is actually the "KY-9005 9-in-1" multicart and runs on NES 2.0 Mapper 260.
- assiged to mapper_260
- tweak chr mixed ram/rom logic check
- minimize updates to address $500x writes when there are no changes to reg values
- fix incompatible pointer type warning
