admin/ci-emsdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pass -DENABLE_WERROR=0 when building Binaryen (#1028)

Browse Source 
* Pass -DENABLE_WERROR=0 when building Binaryen

We are experiencing an issue at our Unity CI with building Binaryen: https://github.com/WebAssembly/binaryen/issues/4588

It seems that for end users, disabling -Werror is a good general measure to enable wider chance of success to build. Emsdk installations are unlikely to be used by Binaryen developers to iterate on Binaryen development, so it is not necessary there?

* Flake
This commit is contained in:
juj
2022-04-13 19:48:00 +03:00
committed by GitHub
parent c2147f3b87
commit 7978a62f2b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
emsdk.py
View File

@@ -1543,7 +1543,7 @@ def build_binaryen_tool(tool):
build_type = decide_cmake_build_type(tool)
# Configure
args = []
args = ['-DENABLE_WERROR=0'] # -Werror is not useful for end users
cmake_generator = CMAKE_GENERATOR
if 'Visual Studio 16' in CMAKE_GENERATOR: # VS2019