From 7978a62f2b4657655375be2b7235d6bb1e8f0c0a Mon Sep 17 00:00:00 2001 From: juj Date: Wed, 13 Apr 2022 19:48:00 +0300 Subject: [PATCH] Pass -DENABLE_WERROR=0 when building Binaryen (#1028) * Pass -DENABLE_WERROR=0 when building Binaryen We are experiencing an issue at our Unity CI with building Binaryen: https://github.com/WebAssembly/binaryen/issues/4588 It seems that for end users, disabling -Werror is a good general measure to enable wider chance of success to build. Emsdk installations are unlikely to be used by Binaryen developers to iterate on Binaryen development, so it is not necessary there? * Flake --- emsdk.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emsdk.py b/emsdk.py index 28040f8..1b5fc79 100644 --- a/emsdk.py +++ b/emsdk.py @@ -1543,7 +1543,7 @@ def build_binaryen_tool(tool): build_type = decide_cmake_build_type(tool) # Configure - args = [] + args = ['-DENABLE_WERROR=0'] # -Werror is not useful for end users cmake_generator = CMAKE_GENERATOR if 'Visual Studio 16' in CMAKE_GENERATOR: # VS2019