admin/ci-emsdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash attempting to install fastcmp SDK by hash (#730)

Browse Source 
Using the full SDK name was causing a crash here because the
version is not of the form 1.2.3.  e.g:

sdk-releases-upstream-3b8cff670e9233a6623563add831647e8689a86b-64bit
This commit is contained in:
Sam Clegg
2021-02-26 08:48:00 -08:00
committed by GitHub
parent f9af08a28f
commit a79eadf893
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
emsdk.py
View File

@@ -2625,14 +2625,14 @@ def expand_sdk_name(name):
elif '-fastcomp' in fullname: elif '-fastcomp' in fullname:
fullname = fullname.replace('-fastcomp', '') fullname = fullname.replace('-fastcomp', '')
backend = 'fastcomp' backend = 'fastcomp'
fullname = fullname.replace('sdk-', '').replace('-64bit', '').replace('tag-', '') version = fullname.replace('sdk-', '').replace('releases-', '').replace('-64bit', '').replace('tag-', '')
if backend == 'fastcomp' and version_key(fullname) >= (2, 0, 0):
exit_with_fastcomp_error()
releases_info = load_releases_info()['releases'] releases_info = load_releases_info()['releases']
release_hash = get_release_hash(fullname, releases_info) release_hash = get_release_hash(version, releases_info)
if release_hash: if release_hash:
if backend == 'fastcomp' and version_key(version) >= (2, 0, 0):
exit_with_fastcomp_error()
if backend is None: if backend is None:
if version_key(fullname) >= (1, 39, 0): if version_key(version) >= (1, 39, 0):
backend = 'upstream' backend = 'upstream'
else: else:
backend = 'fastcomp' backend = 'fastcomp'