From a79eadf89335daa24f749ac9a9d405b9a7ad3836 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Fri, 26 Feb 2021 08:48:00 -0800 Subject: [PATCH] Fix crash attempting to install fastcmp SDK by hash (#730) Using the full SDK name was causing a crash here because the version is not of the form 1.2.3. e.g: sdk-releases-upstream-3b8cff670e9233a6623563add831647e8689a86b-64bit --- emsdk.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/emsdk.py b/emsdk.py index 35783c1..0063bcb 100644 --- a/emsdk.py +++ b/emsdk.py @@ -2625,14 +2625,14 @@ def expand_sdk_name(name): elif '-fastcomp' in fullname: fullname = fullname.replace('-fastcomp', '') backend = 'fastcomp' - fullname = fullname.replace('sdk-', '').replace('-64bit', '').replace('tag-', '') - if backend == 'fastcomp' and version_key(fullname) >= (2, 0, 0): - exit_with_fastcomp_error() + version = fullname.replace('sdk-', '').replace('releases-', '').replace('-64bit', '').replace('tag-', '') releases_info = load_releases_info()['releases'] - release_hash = get_release_hash(fullname, releases_info) + release_hash = get_release_hash(version, releases_info) if release_hash: + if backend == 'fastcomp' and version_key(version) >= (2, 0, 0): + exit_with_fastcomp_error() if backend is None: - if version_key(fullname) >= (1, 39, 0): + if version_key(version) >= (1, 39, 0): backend = 'upstream' else: backend = 'fastcomp'