admin/ci-emsdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't advertise "per_object_debug_info" feature in Bazel. (#969)

Browse Source 
It breaks @emsdk in workspaces that have this feature enabled.

The following error appears when using the latest commit:

    cc_toolchain '@emsdk//emscripten_toolchain:everything' with
    identifier 'emscripten-wasm' doesn't define a tool path for 'dwp'

The following error appears after adding `emdwp` tool and scripts:

    output '*.dwo' was not created

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This commit is contained in:
Piotr Sikora
2022-01-19 17:45:46 -06:00
committed by GitHub
parent 23b3e18db8
commit 61c35abc7a
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bazel/emscripten_toolchain/crosstool.bzl
View File

@@ -298,10 +298,6 @@ def _impl(ctx):
# Blaze also tests if this feature is supported, before setting the "pic" build-variable.
feature(name = "pic"),
# Blaze requests this feature if fission is requested
# Blaze also tests if it's supported to see if we support fission.
feature(name = "per_object_debug_info"),
# Blaze requests this feature by default.
# Blaze also tests if this feature is supported before setting preprocessor_defines
# (...but why?)