From 61c35abc7aa63d83341f47effeea69dacd8b41b7 Mon Sep 17 00:00:00 2001 From: Piotr Sikora Date: Wed, 19 Jan 2022 17:45:46 -0600 Subject: [PATCH] Don't advertise "per_object_debug_info" feature in Bazel. (#969) It breaks @emsdk in workspaces that have this feature enabled. The following error appears when using the latest commit: cc_toolchain '@emsdk//emscripten_toolchain:everything' with identifier 'emscripten-wasm' doesn't define a tool path for 'dwp' The following error appears after adding `emdwp` tool and scripts: output '*.dwo' was not created Signed-off-by: Piotr Sikora --- bazel/emscripten_toolchain/crosstool.bzl | 4 ---- 1 file changed, 4 deletions(-) diff --git a/bazel/emscripten_toolchain/crosstool.bzl b/bazel/emscripten_toolchain/crosstool.bzl index ce87ebb..c1ba75e 100644 --- a/bazel/emscripten_toolchain/crosstool.bzl +++ b/bazel/emscripten_toolchain/crosstool.bzl @@ -298,10 +298,6 @@ def _impl(ctx): # Blaze also tests if this feature is supported, before setting the "pic" build-variable. feature(name = "pic"), - # Blaze requests this feature if fission is requested - # Blaze also tests if it's supported to see if we support fission. - feature(name = "per_object_debug_info"), - # Blaze requests this feature by default. # Blaze also tests if this feature is supported before setting preprocessor_defines # (...but why?)