From deb6453391c3e0da66eee71a14bff64ce73ff713 Mon Sep 17 00:00:00 2001 From: Matt Gucci Date: Tue, 21 Sep 2021 02:02:01 +0900 Subject: [PATCH] Fix error handling: untargz() in emsdk.py (#895) Make untargz() in emsdk.py return False if tar command failed. --- emsdk.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/emsdk.py b/emsdk.py index 0918fb6..18bcf90 100644 --- a/emsdk.py +++ b/emsdk.py @@ -539,10 +539,10 @@ def untargz(source_filename, dest_dir, unpack_even_if_exists=False): return True print("Unpacking '" + source_filename + "' to '" + dest_dir + "'") mkdir_p(dest_dir) - run(['tar', '-xvf' if VERBOSE else '-xf', sdk_path(source_filename), '--strip', '1'], cwd=dest_dir) + returncode = run(['tar', '-xvf' if VERBOSE else '-xf', sdk_path(source_filename), '--strip', '1'], cwd=dest_dir) # tfile = tarfile.open(source_filename, 'r:gz') # tfile.extractall(dest_dir) - return True + return returncode == 0 # On Windows, it is not possible to reference path names that are longer than