From deaa7e4bfd79246f02f785c8f2174d1e74ab6c00 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Tue, 28 Jan 2020 17:12:31 -0800 Subject: [PATCH] Hide npm output by default (#431) Fixes: https://github.com/emscripten-core/emscripten/issues/10291 --- .flake8 | 1 + emsdk.py | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.flake8 b/.flake8 index d007a0d..31829b5 100644 --- a/.flake8 +++ b/.flake8 @@ -9,6 +9,7 @@ exclude = ./gnu ./upstream ./fastcomp + ./fastcomp-clang ./releases ./clang ./emscripten diff --git a/emsdk.py b/emsdk.py index d382d31..d460e3d 100755 --- a/emsdk.py +++ b/emsdk.py @@ -1276,7 +1276,17 @@ def emscripten_npm_install(tool, directory): npm = os.path.join(node_path, 'npm' + ('.cmd' if WINDOWS else '')) env = os.environ.copy() env["PATH"] = node_path + os.pathsep + env["PATH"] - subprocess.check_call([npm, 'ci', '--production'], cwd=directory, env=env) + print('Running post-install step: npm ci ...') + try: + subprocess.check_output( + [npm, 'ci', '--production'], + cwd=directory, stderr=subprocess.STDOUT, env=env, + universal_newlines=True) + except subprocess.CalledProcessError as e: + print('Error running %s:\n%s' % (e.cmd, e.output)) + return False + + print('Done running: npm ci') return True