From 8f2f5e3435f6d0978469406a344a57a0d558deb1 Mon Sep 17 00:00:00 2001 From: juj Date: Sun, 8 Nov 2020 14:52:43 +0200 Subject: [PATCH] Fix regression where reinstalling tools from git sources would not git pull and rebuild them. (#647) --- emsdk.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/emsdk.py b/emsdk.py index 1e33b94..1ac1e05 100644 --- a/emsdk.py +++ b/emsdk.py @@ -1862,7 +1862,11 @@ class Tool(object): return True def install_tool(self): - if self.is_installed(): + # Avoid doing a redundant reinstall of the tool, if it has already been installed. + # However all tools that are sourced directly from git branches do need to be + # installed every time when requested, since the install step is then used to git + # pull the tool to a newer version. + if self.is_installed() and not hasattr(self, 'git_branch'): print("Skipped installing " + self.name + ", already installed.") return True