admin/ci-emsdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix macOS build (#996)

Browse Source 
* Fix macOS build. See https://github.com/WebAssembly/binaryen/issues/4299

* Update comment
This commit is contained in:
juj
2022-03-23 09:32:54 +02:00
committed by GitHub
parent 637777bd62
commit 497595e830
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
emsdk.py
View File

@@ -1033,16 +1033,16 @@ def cmake_configure(generator, build_root, src_root, build_type, extra_cmake_arg
generator = [] generator = []
cmdline = ['cmake'] + generator + ['-DCMAKE_BUILD_TYPE=' + build_type, '-DPYTHON_EXECUTABLE=' + sys.executable] cmdline = ['cmake'] + generator + ['-DCMAKE_BUILD_TYPE=' + build_type, '-DPYTHON_EXECUTABLE=' + sys.executable]
# Target macOS 10.11 at minimum, to support widest range of Mac devices from "Mid 2007" and newer: # Target macOS 10.14 at minimum, to support widest range of Mac devices from "Early 2008" and newer:
# https://en.wikipedia.org/wiki/MacBook_Pro#Supported_macOS_releases # https://en.wikipedia.org/wiki/MacBook_(2006–2012)#Supported_operating_systems
cmdline += ['-DCMAKE_OSX_DEPLOYMENT_TARGET=10.11'] cmdline += ['-DCMAKE_OSX_DEPLOYMENT_TARGET=10.14']
cmdline += extra_cmake_args + [src_root] cmdline += extra_cmake_args + [src_root]
print('Running CMake: ' + str(cmdline)) print('Running CMake: ' + str(cmdline))
# Specify the deployment target also as an env. var, since some Xcode versions # Specify the deployment target also as an env. var, since some Xcode versions
# read this instead of the CMake field. # read this instead of the CMake field.
os.environ['MACOSX_DEPLOYMENT_TARGET'] = '10.11' os.environ['MACOSX_DEPLOYMENT_TARGET'] = '10.14'
def quote_parens(x): def quote_parens(x):
if ' ' in x: if ' ' in x: