admin/ci-emsdk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing comma from #1429 (#1433)

Browse Source 
Turns out this is what was causing the OOM when building binaryen since
we were clobbering the EMSDK_NUM_CORES environment variable by mistake.

See #1429
This commit is contained in:
Sam Clegg
2024-07-31 18:59:43 -07:00
committed by GitHub
parent fad40cf1f4
commit 476dc4e01f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
emsdk.py
View File

@@ -2632,7 +2632,7 @@ def construct_env_with_vars(env_vars_to_add):
# of the SDK but we want to remove that from the current environment # of the SDK but we want to remove that from the current environment
# if no such tool is active. # if no such tool is active.
# Ignore certain keys that are inputs to emsdk itself. # Ignore certain keys that are inputs to emsdk itself.
ignore_keys = set(['EMSDK_POWERSHELL', 'EMSDK_CSH', 'EMSDK_CMD', 'EMSDK_BASH', 'EMSDK_FISH' ignore_keys = set(['EMSDK_POWERSHELL', 'EMSDK_CSH', 'EMSDK_CMD', 'EMSDK_BASH', 'EMSDK_FISH',
'EMSDK_NUM_CORES', 'EMSDK_NOTTY', 'EMSDK_KEEP_DOWNLOADS']) 'EMSDK_NUM_CORES', 'EMSDK_NOTTY', 'EMSDK_KEEP_DOWNLOADS'])
env_keys_to_add = set(pair[0] for pair in env_vars_to_add) env_keys_to_add = set(pair[0] for pair in env_vars_to_add)
for key in os.environ: for key in os.environ: