CI: Build latest docker image rather than tot (#1359)

This means that CI run that update `latest` actually test the thing
we are about to ship.

We recently had a case where `latest` was broken but `tot` was fixes
and we accidentally shipped a broken SDK version (#1353).
This commit is contained in:
Sam Clegg
2024-03-14 09:45:41 -07:00
committed by GitHub
parent da5a19215a
commit 44bf7cfbe6
2 changed files with 4 additions and 4 deletions

View File

@@ -181,13 +181,13 @@ jobs:
name: install docker name: install docker
command: apt-get update -q && apt-get install -q -y docker.io command: apt-get update -q && apt-get install -q -y docker.io
- setup_remote_docker - setup_remote_docker
# Build and test the tip-of-tree build of EMSDK # Build the `latest` version of EMSDK as docker image
- run: - run:
name: build name: build
command: make -C ./docker version=tot build command: make -C ./docker version=latest build
- run: - run:
name: test name: test
command: make -C ./docker version=tot test command: make -C ./docker version=latest test
publish-docker-image-x64: publish-docker-image-x64:
executor: bionic executor: bionic

View File

@@ -14,7 +14,7 @@ ifndef version
endif endif
build: Dockerfile .TEST build: Dockerfile .TEST
cd .. && docker build --network host --build-arg=EMSCRIPTEN_VERSION=${version} -t ${image_name}:${version} -f docker/$< . cd .. && docker build --progress=plain --network host --build-arg=EMSCRIPTEN_VERSION=${version} -t ${image_name}:${version} -f docker/$< .
test: test_dockerimage.sh .TEST test: test_dockerimage.sh .TEST
# test as non-root # test as non-root