From 2b10b1bfc31ca467618bc171231dcd4b4d8b2430 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Fri, 3 Oct 2025 15:34:43 -0700 Subject: [PATCH] Use default python in PATH for circleci windows bot. NFC (#1609) `C:\Python312\python.exe` is already in the path by default. We no longer need to set this special path or environment variable. In fact this code was doing nothing since it was adding the end of the PATH so the system python was already coming first. --- .circleci/config.yml | 11 +++-------- test/test.bat | 1 - 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 59de9a0..54f05b2 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -138,22 +138,17 @@ jobs: name: win/server-2019 shell: bash.exe environment: - # We need python installed before we can test anytyhing. - # There seems to be undocument copy of python installed here. Hopefully - # if this disappears there will be another way of getting a re-installed - # version. - PYTHON_BIN: "C:\\Python27amd64" PYTHONUNBUFFERED: "1" EMSDK_NOTTY: "1" steps: - checkout - - run: - name: Add python to bash path - command: echo "export PATH=\"$PATH:/c/python27amd64/\"" >> $BASH_ENV + - run: where python + - run: name: Install latest shell: cmd.exe command: test\test.bat + - run: name: test.py command: | diff --git a/test/test.bat b/test/test.bat index c39bb3c..acdf444 100755 --- a/test/test.bat +++ b/test/test.bat @@ -1,5 +1,4 @@ :: equivalent of test.sh as windows bat file -set PATH=%PATH%;%PYTHON_BIN% CALL emsdk install latest CALL emsdk activate latest CALL emsdk_env.bat